Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Yip
Here's another one (now using a branch).
There's an issue with the figure attributes attr and attrlink.
{{< figure thumb="-thumb" link="/img/hugo-dolor.png" size="900x450" caption="foo" attr="(c) by bar" attrlink="https://www.example.com" >}}
leads to an error:
ERROR 2018/01/10 15:07:44 error processing shortcode "shortcodes/figure.html" for page "post/test-heg-figure-attrlink.md": template: shortcodes/figure.html:23:57: executing "shortcodes/figure.html" at <.Get>: can't evaluate field Get in type string
I fixed that and improved the captions. If a figure has an attribution it needs to be shown:
https://stackoverflow.com/questions/21483356/how-to-mark-the-copyright-of-an-image-in-html
So I did:
figure.html:
load-photoswipe.js:
title : ($title ? $title : "") + ($title_footer ? ($title ? "<br/><small>" : "") + $title_footer + ($title ? "</small>" : "" ) : "")
load-photoswipe.html, load-photoswipe-theme.html, hugo-easy-gallery.css:
Adjust color for a tag
(Kind of ugly in the html files, maybe you see a better way)
hugo-easy-gallery.css I did ad well:
You have this in https://www.liwen.id.au/css/main.css as well.
Without it, the thumbs are cropped. It took me a while until I figured that on out.
Test site:
https://github.com/it-gro/HugoTestingHegAttrIssue
Kind regards