Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LVN template parser #208

Merged
merged 6 commits into from
Oct 25, 2024
Merged

LVN template parser #208

merged 6 commits into from
Oct 25, 2024

Conversation

bcardarella
Copy link
Contributor

No description provided.

@bcardarella
Copy link
Contributor Author

bcardarella commented Oct 23, 2024 •
edited
Loading

This PR will provide a Floki-compatible template parser

This enables completing inputs_for/1 and getting the test suite ready for integration testing LVN

@leandrocp
Copy link

Hey @bcardarella that's interesting. You might want to take a look at philss/floki#463
Floki has introduced attrs as maps to facilitate testing so it might be useful for LVN as well.

@bcardarella
Copy link
Contributor Author

Good catch! That should be fairly easy to implement once I cover some more of the edge cases in the parser

@bcardarella
Copy link
Contributor Author

@leandrocp done: 828708d

@bcardarella bcardarella changed the title First implementation of LVN template parser LVN template parser Oct 24, 2024
@bcardarella bcardarella marked this pull request as ready for review October 25, 2024 13:06
@bcardarella bcardarella merged commit c3ec177 into main Oct 25, 2024
1 check passed
@bcardarella bcardarella deleted the bc-lvn-template-parser branch October 25, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcardarella @leandrocp