Combine Heartbeats #575
Merged
Combine Heartbeats #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Merged
ecmulli
reviewed
Aug 17, 2024
| const mergedEvent: HeartbeatEvent = { | ||
| ...existingEvent, | ||
| id: existingEvent.id, | ||
| timestamp: Math.max(existingEvent.timestamp, newEvent.timestamp), |
There was a problem hiding this comment.
we talked about having another timestamp field to capture the original heartbeat. I like the idea of having timestamp as the latest one. just need one that is set on the original event.
There was a problem hiding this comment.
This will be shipped in the next release. Thanks for the reminder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated all dependencies and changed to have a single heartbeat event when multiple heartbeats are attempted to be sent.