Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AI LLM endpoint #2319

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Add AI LLM endpoint #2319

merged 4 commits into from
Oct 7, 2024

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Oct 2, 2024

What does this pull request do? Explain your changes. (required)

Adding a new AI endpoint for LLM.

Specific updates (required)

How did you test each of these updates (required)

Testing in staging and unit testing.

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@mjh1 mjh1 requested a review from a team as a code owner October 2, 2024 13:25
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 9:21am

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

it("should call the AI Gateway for generate API /llm", async () => {
const res = await client.fetch("/beta/generate/llm", {
method: "POST",
body: buildForm({ prompt: "foo" }),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol so the LLM API is a multipart form even tho there's no files in the payload? or is it multi-modal and could receive files? if it could, I'd say we test with a dummy file here as well just in case

Copy link
Contributor Author

@mjh1 mjh1 Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah.... it did strike me as odd too but wasn't sure. there aren't any file fields in the spec 😬 Maybe we're futureproofing..?

@mjh1 mjh1 merged commit d25ae47 into master Oct 7, 2024
13 checks passed
@mjh1 mjh1 deleted the mh/llm branch October 7, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants