Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add procps, vnstat, linux-tools #738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add procps, vnstat, linux-tools #738

wants to merge 1 commit into from

Conversation

emranemran
Copy link
Collaborator

@emranemran emranemran commented Nov 14, 2023

  • procps so we upgrade the version of top running on our pods and get access to better info.
  • vnstat so we can do bandwidth calcs in catabalancer
  • linux-tools so we can have perf by default in the pods which have been useful for flamegraphs (cc @victorges)

Copy link
Contributor

@iameli iameli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure but you can't rely on it being there any time soon, we don't roll pods much. What would you think of using this in catalyst-api instead? We're going to need something like it for the load balancing work. https://github.com/cloudfoundry/gosigar

@iameli
Copy link
Contributor

iameli commented Nov 30, 2023

@emranemran Do we still need this with all the system monitoring stuff landing in catabalancer?

@emranemran
Copy link
Collaborator Author

@emranemran Do we still need this with all the system monitoring stuff landing in catabalancer?

yes! this helps with per-process cpu/mem usage during specific operations in catalyst-api and the inter-parsing of these logs with catalyst-api helps narrow down issues quicker.

@emranemran
Copy link
Collaborator Author

hmm do we think we don't need to reference it by kernel version?


3.894 Reading state information...
3.913 3 packages can be upgraded. Run 'apt list --upgradable' to see them.
3.927 
3.928 WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
3.928 
: Couldn't find any package by glob 'linux-tools-5.4.0-148-generic'

``` 

@emranemran emranemran changed the title add procps add procps, vnstat, linux-tools Dec 12, 2023
Dockerfile Outdated
@@ -80,6 +80,9 @@ RUN apt update && apt install -yqq \
ffmpeg \
nodejs \
gstreamer1.0-tools gstreamer1.0-plugins-good gstreamer1.0-plugins-base gstreamer1.0-plugins-bad \
procps \
vnstat \
linux-tools-common linux-tools-generic linux-tools-5.4.0-148-generic \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linux-tools-generic alone should be enough. it should pick up correct linux-tools-<version>-generic based on installed kernel version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, updating.

Copy link
Contributor

@iameli iameli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@iameli
Copy link
Contributor

iameli commented Dec 12, 2023

Tests failing though, you. should rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants