Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use errgroup to write segments to disk in background #998

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Use errgroup to write segments to disk in background

e211fe0
Select commit
Loading
Failed to load commit list.
Open

Use errgroup to write segments to disk in background #998

Use errgroup to write segments to disk in background
e211fe0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 9, 2024 in 0s

52.43504% (-0.01015%) compared to 1ba6bd7

View this Pull Request on Codecov

52.43504% (-0.01015%) compared to 1ba6bd7

Details

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (1ba6bd7) 52.44519% compared to head (e211fe0) 52.43504%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #998         +/-   ##
===================================================
- Coverage   52.44519%   52.43504%   -0.01015%     
===================================================
  Files             70          70                 
  Lines           7709        7659         -50     
===================================================
- Hits            4043        4016         -27     
+ Misses          3344        3322         -22     
+ Partials         322         321          -1     
Files Coverage Δ
video/media.go 100.00000% <100.00000%> (+13.04348%) ⬆️
transcode/transcode.go 35.95506% <23.07692%> (+1.04127%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba6bd7...e211fe0. Read the comment docs.

Files Coverage Δ
video/media.go 100.00000% <100.00000%> (+13.04348%) ⬆️
transcode/transcode.go 35.95506% <23.07692%> (+1.04127%) ⬆️