Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the timbrooks/instruct-pix2pix model #52

Closed
wants to merge 5 commits into from

Conversation

stronk-dev
Copy link
Contributor

No description provided.

@stronk-dev
Copy link
Contributor Author

Since pix2pix has yet another parameter (image_guidance_scale), we probably want some more changes. We also need a better way to get a default inference_steps value. I think for most dApps they want a sensible default so they don't hjave to bother thinking about it, but it has so much influence in inference time and output quality. And the 'best' defaults differs depending on model and scheduler used

@stronk-dev
Copy link
Contributor Author

Also still needs adjustment to set "fp16" automatically

@rickstaa
Copy link
Collaborator

Replaced by #94.

@rickstaa rickstaa closed this May 31, 2024
@rickstaa
Copy link
Collaborator

rickstaa commented Jun 4, 2024

@stronk-dev I currently decided for transparency to use the models default. I however agree that in the future it would make sense to set more sensible defaults and enforce fp16. I created a linear item for it 👍🏻.

@rickstaa rickstaa deleted the pix2pix branch June 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants