Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prometheus credentials to helm chart #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

holzgeist
Copy link

No description provided.

@holzgeist
Copy link
Author

@davidzhao this is an attempt to bring livekit/livekit#2252 over to the helm chart. It's currently completely untested because I don't fully understand how to test local changes with flux/helm/... yet.
I'll try again next week, unless you get to it before me 😇

@holzgeist holzgeist marked this pull request as ready for review February 19, 2024 13:59
@holzgeist holzgeist force-pushed the feat-add-prometheus-credentials branch from 24ef91f to 8d6b2d1 Compare October 8, 2024 11:55
@holzgeist
Copy link
Author

@davidzhao Meantime I figured out how to develop and test helm charts 😄

Here's an update PR that allows credentials to be set. They are

  • passed in plain test into livekits config map so livekit can load them
  • stored in a secret so that the service monitor can load them (with a configurable secret name via .Values.serviceMonitor.secretName)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant