Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds creationTime to Room attributes #532

Closed
wants to merge 3 commits into from
Closed

Conversation

yepher
Copy link

@yepher yepher commented Dec 15, 2024

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chris Wilson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hiroshihorie
Copy link
Member

hiroshihorie commented Dec 17, 2024

Hi, thanks for your PR!
I think it might be better to expose it as a Date (UTC) var for better dev experience. 🤔 @bcherry

@bcherry
Copy link
Contributor

bcherry commented Dec 17, 2024

agree - that would match the format of Participant.joinedAt

@hiroshihorie
Copy link
Member

@yepher Can you push changes @bcherry suggests ? Otherwise I can push a fix.

@yepher
Copy link
Author

yepher commented Dec 31, 2024

@yepher Can you push changes @bcherry suggests ? Otherwise I can push a fix.

@hiroshihorie Please go for it. I showed you an example of what you must do to get what you need. I am not actively working on Swift, so please do it since you are the one who needs it and is actively working on it.

@hiroshihorie
Copy link
Member

@yepher Can you sign the CLA ?

@andreasteich
Copy link

@hiroshihorie any news on when the property is available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants