-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom video frame processing #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty simple which is great. is there any particular reason why the interface can't be on track instead of on capturer? that would more cleanly match how we do it on the other sdks
@bcherry Good point, will check other SDK interface and try to align 🙂 |
@bcherry createCameraTrack(processor:) is available now and also exposed LocalVideoTrack.processor property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! lgtm.
What is the behavior if you do fail to process frames fast enough? It does sound like dropping frames would be the right behavior if we're still processing older ones. we'd want to have the same behavior across every SDK - does JS do anything like this @lukasIO ?
there's no timeout for frame processing in the JS processors we provide. |
if your input video is coming from the camera at 30fps but your processor takes longer than 1/30th of a second to process each frame, what will the users experience? It seems like we should do something here at the framework level to guide users into a happy path that just works? |
No description provided.