Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle RTCPeerConnection error on replaceTrack #1321

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

conroywhitney
Copy link

Changes

  • Catch / log InvalidStateError: RTCPeerConnection is closed exception

Repro

  1. In Safari / Firefox (not Chrome / Edge)
  2. After a region change / reconnection
  3. With or without audio processing (Krisp) on
  4. When trying to un-mute with localParticipant.setMicrophoneEnabled
  5. Before: it would raise the InvalidStateError: RTCPeerConnection is closed error and remain muted
  6. After: we can catch the error, but it still doesn't un-mute

Screenshots

Uncaught

Screenshot 2024-11-19 at 1 12 09 PM

Krisp Off

Screenshot 2024-11-19 at 1 04 56 PM

Krisp On

Screenshot 2024-11-19 at 1 02 36 PM

Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 1c7d315

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants