Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom deepgram base url #1088

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

milo157
Copy link

@milo157 milo157 commented Nov 14, 2024

No description provided.

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: 183fb7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-plugins-deepgram Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm! Can you run ruff format && ruff check --fix

@theomonnom
Copy link
Member

It seems like I don't have write access to this PR, can you click on the changesets comment to add one 🙏

Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these lines are needed?

Comment on lines 197 to 198
"base_url": self._base_url,
"base_url_ws": self._base_url_ws,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"base_url": self._base_url,
"base_url_ws": self._base_url_ws,

Comment on lines 313 to 314
"base_url": self._base_url,
"base_url_ws": self._base_url_ws,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"base_url": self._base_url,
"base_url_ws": self._base_url_ws,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants