fix: conversation item create and delete return a Future #1085
+55
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longcw
force-pushed
the
fix/conversation-item-create
branch
from
622047b
to
3c35c37
Compare
🦋 Changeset detectedLatest commit: 3c35c37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
theomonnom
approved these changes
Nov 14, 2024
theomonnom
reviewed
Nov 14, 2024
| @@ -541,7 +544,8 @@ def create( | |||
| message, | |||
| extra=self._sess.logging_extra(), | |||
| ) | |||
| return | |||
| fut.set_result(False) | |||
| return fut | |||
There was a problem hiding this comment.
I know it's been like that before, but just thinking out loud, should we raise an Exception instead of logging a warning? Since the creation failed anyway
There was a problem hiding this comment.
What do you think if we let the user of this method to decide the agent to keep running or be failed based on the value of the Future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.