Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename asset to lkRed to conform to existing usage #26

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

speakermagnet
Copy link

Motivation: An asset currently being used in swift-example is the color lkRed. Origin branch included unused asset LKRed.colorset in Assets.xcassets.

Changes made:

  • renamed LKRed.colorset to lkRed-temp.colorset then to lkRed.colorset.
    Simple case changes via renaming did not trigger case-insensitive git therefore 2 commits were needed.
  • Modified my .gitignore to avoid local project specific files.
    Unclear if these changes should also be part of repo to avoid future conflicts

Please review the changes and let me know if any further modifications are required.

…ince git is case insensitive I first need to rename to a different name entirely, commit the changes, then later I will change the name back to the original with the correct capitalization.
… capitalization. This effort was performed to get around the limitation that git on this system (and apparently whoever committed origin) is case-insensitive.
@speakermagnet speakermagnet marked this pull request as ready for review September 16, 2023 17:17
@hiroshihorie
Copy link
Collaborator

Can you resolve the merge conflicts

@hiroshihorie
Copy link
Collaborator

I also want to include xcworkspace file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants