Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FrameBuffer nestability due to poor performance. #230

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

LeHaine
Copy link
Member

@LeHaine LeHaine commented Jan 31, 2024

Multiple calls to glGetIntegerv caused poor performance when using multiple FBOs. Removing such kills the ability to nest FBOs upon each other.

FrameBuffer.end() will now bind to the default framebuffer and takes an optional viewport position and size.

@LeHaine LeHaine added enhancement New feature or request graphics Graphics related issues labels Jan 31, 2024
@LeHaine LeHaine merged commit 4430ccf into master Jan 31, 2024
@LeHaine LeHaine deleted the fbo-optimization branch January 31, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request graphics Graphics related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant