This repository has been archived by the owner on Sep 30, 2019. It is now read-only.
--dynamodb-port CLI arg works again #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottAP108
commented
Jul 29, 2019
| @@ -5,6 +5,7 @@ const { DynamoDB } = require('aws-sdk'); | |||
| async function deriveDynamoDBClient( | |||
| { DynamoDB: config }, | |||
| emulatorPath = process.cwd(), | |||
| port, | |||
There was a problem hiding this comment.
This was only specifying two parameters when it was actually receiving three arguments from bin/server. That third argument is the dynamodb port specified via CLI.
ScottAP108
commented
Jul 29, 2019
| @@ -19,7 +20,6 @@ async function deriveDynamoDBClient( | |||
| // start the dynamodb emulator | |||
| const dynamoEmulator = require('@conduitvc/dynamodb-emulator'); | |||
| const dbPath = path.join(path.dirname(emulatorPath), '.dynamodb'); | |||
| const { port } = config; | |||
There was a problem hiding this comment.
This part of the function should not be using the config. This is for a default config, which is hardcoded in config.js as
module.exports = {
DynamoDB: {
emulator: true,
},
};
So there is no port here, which means port will always be undefined. Instead, this line should be eliminated, and the port value passed in from the CLI should be used to launch the emulator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--dynamodb-port. I have fixed this by restoring a missing function parameter for the port and using that when there is no custom config file.