Update workflow configmap model #591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the 2.7+ format so all config not overwritten when patch will be introduce Signed-off-by: Calvin Audier <[email protected]>
- Rename the function - Use kubernetes patch instead of kubernetes update Signed-off-by: Calvin Audier <[email protected]>
- It was removed to allow overwrite others values in the executor section - As this value was static it will be added back from in the default configmap value. (This mean the configuration will still be there and we can even overwrite now) Signed-off-by: Calvin Audier <[email protected]>
Calvinaud
force-pushed
the
update-workflow-configmap-model
branch
from
a16a713
to
ff69876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
litmuschaos/litmus-helm#405
This PR update the litmus-helm-agent so instead of updating the workflow-controller-configmap it will patch it.
This is will allow to pass custom workflow-controlelr-configmap and so it's not overwrittent by the litmus-helm-agent.
Special notes for your reviewer:
At the moment, one configuration was removed from the helm-agent (the executor.imagePullPolicy) that will be added directly from the helm configuration to allow custom configuration in the "executor" section.