Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image registry bug fix #4887

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Image registry bug fix #4887

merged 7 commits into from
Oct 7, 2024

Conversation

aditya3103
Copy link
Contributor

Proposed changes

Image Registry value was not being fetched and reflected in the chaos studio yaml section, it was always overriding and applying the default image registry values

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@aditya3103
fix: fetch image registry data correctly in StudioOverviewView
2999587 
Fixes an issue where the image registry data was not being fetched

Why:
Previously, the image registry data was not being fetched, even though ExperimentMetadata has a field ‘imageRegistry’. This change ensures that the form receives the correct image registry data.

How:
Added a check for loading state by disabling the ‘next’ button and assigned the fetched image registry data to a variable before form submission. This ensures the `values.imageRegistry` field is populated correctly.

Signed-off-by: Aditya Sridasyam <[email protected]>
@aditya3103
fix: passed imageRegistry in kubernetesBlankCanvasTemplate
fac5da6 
Fixes an issue where the image registry data was not being passed in the kubernetesBlankCanvasTemplate function

Why:
kubernetesBlankCanvasTemplate is expecting imageRegistry but never being passed, it is overridden always by default imageRegistry values.

Signed-off-by: Aditya Sridasyam <[email protected]>
@aditya3103
Copy link
Contributor Author

aditya3103 commented Sep 16, 2024 •
edited
Loading

DCO is correctly signed, used my real name instead of GitHub username as per the CONTRIBUTING doc @namkyu1999

@imrajdas
Copy link
Member

Thanks @aditya3103 for this PR , the github pipelines are running now.

@aditya3103
Rectified import order
5c565f7 
imported @utils before `./StudioOverview.module.scss`, rectified as per the frontend check pipeline error 

Signed-off-by: aditya3103 <[email protected]>
@aditya3103
Copy link
Contributor Author

I have rectified the import order which was resulting in an error in the frontend build pipeline @imrajdas

@aditya3103
Copy link
Contributor Author

aditya3103 commented Sep 23, 2024 •
edited
Loading

Should I also fix the warnings from the Codacy Static Code Analysis ? @amityt @imrajdas @namkyu1999

@amityt
Copy link
Contributor

amityt commented Sep 30, 2024

Should I also fix the warnings from the Codacy Static Code Analysis ? @amityt @imrajdas @namkyu1999

Sure @aditya3103 , just checked the codacy review, those are some minor change, will be good if you can add them. Thanks! 🙌🏼

@aditya3103
Copy link
Contributor Author

aditya3103 commented Sep 30, 2024 •
edited
Loading

Should I also fix the warnings from the Codacy Static Code Analysis ? @amityt @imrajdas @namkyu1999

Sure @aditya3103 , just checked the codacy review, those are some minor change, will be good if you can add them. Thanks! 🙌🏼

I have fixed all the warning from codacy, hope it is merge-worthy now !
@amityt @imrajdas

@Saranya-jena Saranya-jena merged commit 29e7130 into litmuschaos:master Oct 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amityt amityt amityt approved these changes

@Saranya-jena Saranya-jena Saranya-jena approved these changes

@hrishavjha hrishavjha hrishavjha approved these changes

Assignees

@aditya3103 aditya3103

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aditya3103 @imrajdas @amityt @hrishavjha @Saranya-jena