mmap: make CSR optional #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropping the dummy_bits CSR can help to save area in very congested designs.
danc86
added a commit
to danc86/CFU-Playground
that referenced
this pull request
Feb 2, 2022
Switch to litespi fork in order to pull in litex-hub/litespi#67
|
At first I was worried that this somehow broke my design, but it turned out to be a totally unrelated issue in nextpnr which happened to use some unimplemented elements: YosysHQ/nextpnr#903 So I can confirm this change is good to go. It gives us a modest but nevertheless useful reduction in resource usage. |
|
@kgugala - Who from Antmicro should review this pull request? |
|
Thanks @danc86, this looks good and is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping the dummy_bits CSR can help to save area in very congested
designs.