Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Fixes - System Changes - Code Refactoring - Mega Merge #17

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

GalloDaSballo
Copy link
Collaborator

@GalloDaSballo GalloDaSballo commented Oct 10, 2024

Mega PR of all changes

5.1 -> WIP

Fix: 5.2 - Try Catch that actually doesn't revert - #5

  • Fix known vector such as: selfdestruct, returnbomb, gasgrief and reverts
  • Discuss Gas to Hooks
  • Basic Tests
  • Invariant Testing on Governance to prevent any DOS | cc: @nican0r | High impact | Mid Prio
  • Invariant Testing Setup to test Initiatives to verify if they are safe to use | cc: @nican0r | Low Prio | High Impact

Fix: 5.3 - fix: counted ts fix - #18

  • Write tests to identify the bug
  • Write fuzz / invariant tests to ensure the bug doesn't happen again
    @nican0r need coverage here pls

5.4 - WIP - See: #16

5.5 - WIP - CC: @nican0r

Fix: 5.6 - see 5.2

5.7 -> See 5.4

5.8 -> See 5.4

Fix: 5.9 - Curve Claim Flow + Tests + Griefing - #10

  • Needs true E2E Forked Tests

5.10 -> See 5.4

5.11

Awaiting @jltqy See: fix/voteCheck
May rewrite these

5.12

Ack -> TODO: Review Game Theory

Rest

  • TODO Later

Pending

NOT MERGED - Fix: V4 Claim Grief Flow - #11

  • Does the hook work?
  • Does the vesting work
  • E2E Fork Test

Minor

Unchecked ETH Transfer - #7

  • Adds a check
  • Should we allow specifying a different recipient?

Always use safeTransfer | bcf897e

  • TODO: Decide if we want to remove all of them since approve is not safe and bold and lqty don't require it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant