Audit Fixes - System Changes - Code Refactoring - Mega Merge #17
+473
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mega PR of all changes
5.1 -> WIP
Fix: 5.2 - Try Catch that actually doesn't revert - #5
selfdestruct
,returnbomb
,gasgrief
andreverts
Fix: 5.3 - fix: counted ts fix - #18
@nican0r need coverage here pls
5.4 - WIP - See: #16
5.5 - WIP - CC: @nican0r
Fix: 5.6 - see 5.2
5.7 -> See 5.4
5.8 -> See 5.4
Fix: 5.9 - Curve Claim Flow + Tests + Griefing - #10
5.10 -> See 5.4
5.11
Awaiting @jltqy See:
fix/voteCheck
May rewrite these
5.12
Ack -> TODO: Review Game Theory
Rest
Pending
NOT MERGED - Fix: V4 Claim Grief Flow - #11
Minor
Unchecked ETH Transfer - #7
Always use
safeTransfer
| bcf897eapprove
is not safe and bold and lqty don't require it