New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add explicit overflow checks to math library and tests #15

Open

GalloDaSballo wants to merge 1 commit into liquity:fix/voteCheck from GalloDaSballo:alex-fix/voteCheck

Collaborator

GalloDaSballo commented Oct 9, 2024 •

edited

Loading

Updates the Math library to have explicit overflow checks
Tests the overflow checks
Would benefit by another pair of eyes
TODO: Prove we can never get a call to abs with the type(int96).min


fix: add explicit overflow checks to math library and tests

2917be6

Collaborator

jltqy commented Oct 9, 2024

We can lower the size of int96 to int88 here

Collaborator Author

GalloDaSballo commented Oct 10, 2024

Please proceed with the change @jltqy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment