[liqoctl] allow override gateway client address and port #2831
+59
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces the `--client-address` and `--client-port` to the `peer` and `connect` commands of `liqoctl` to override the value written in the endpoint field of the status of the GatewayServer resource, which is used to configure the GatewayClient resource. This is useful especially when the gateway server is not directly reachable by the client (e.g. it is behind a NAT).
|
Hi @claudiolor. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
claudiolor
force-pushed
the
clo/override-client-endpoint
branch
from
d99735e
to
2d54b75
Compare
aleoli
approved these changes
Nov 26, 2024
This patch removes the possibility to use the override the address and port used by the client to connect to the GatewayServer via the `liqo.io/override-address` and `liqo.io/override-port` annotation. Introduced with PR liqotech#2384
claudiolor
force-pushed
the
clo/override-client-endpoint
branch
from
2d54b75
to
cb3c61e
Compare
fra98
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Should we remove this file now? Since it's identical to the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment to override the address and port used by the gateway client when peering is done via liqoctl is handled via an annotation to be placed on the gateway server template resource. However, this has some limitations:
To fix this issue this PR introduces the
--client-addressand--client-portto thepeerandconnectcommands ofliqoctlto override the value written in the endpoint field of the status of the GatewayServer resource, which is used to configure the GatewayClient resource. This is useful especially when the gateway server is not directly reachable by the client (e.g. it is behind a NAT).