Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to create capture area TDE-1159 #566

Merged
merged 3 commits into from
May 7, 2024

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented May 6, 2024

Motivation

Give the user control of whether we create capture areas for datasets. This is a workaround for some footprints resulting in unusably complex capture areas.

Modification

New create_capture_area parameter, passed through as --create-footprints.

Depends on linz/topo-imagery#959.

Checklist

  • Tests updated (N/A)
  • Docs updated
  • Issue linked in Title

@l0b0 l0b0 requested review from a team as code owners May 6, 2024 03:22
@l0b0 l0b0 enabled auto-merge May 6, 2024 21:38
@paulfouquet
Copy link
Collaborator

When create-collection step is called, as there are no footprints, capture area is not created.

@paulfouquet
Copy link
Collaborator

paulfouquet commented May 6, 2024

Might be worth checking how Argo Workflows behaves when the capture-area is not found.
EDIT: From a test (test-env-99cwt workflow), the task fails

Error (exit code 1): open /var/run/argo/outputs/artifacts/tmp/capture-area.geojson.tgz: no such file or directory

EDIT 2: There is an optional that seems to work from my test

@l0b0 l0b0 added this pull request to the merge queue May 7, 2024
Merged via the queue into master with commit 7b6c360 May 7, 2024
3 checks passed
@l0b0 l0b0 deleted the feat/give-option-create-capture-area-tde-1159 branch May 7, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants