Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable Basemaps preview for Elevation data TDE-1151 BM-932 #543

Merged
merged 3 commits into from
Apr 18, 2024
Merged

fix: enable Basemaps preview for Elevation data TDE-1151 BM-932 #543

merged 3 commits into from
Apr 18, 2024

Conversation

amfage
Copy link
Contributor

@amfage amfage commented Apr 17, 2024 •
edited
Loading

Motivation

Enable the Basemaps configuration for dem_lerc, as Basemaps now supports previewing Elevation data.

Modification

Remove exclusion for dem_lerc preset.

Checklist

  • Tests updated N/A
  • Docs updated
  • Issue linked in Title

@amfage amfage requested review from a team as code owners April 17, 2024 23:22
l0b0
l0b0 reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but it would be good to understand why we excluded the DEM LERC files before, and what's changed to make us include them again.

@amfage
Copy link
Contributor Author

amfage commented Apr 17, 2024

The code looks good, but it would be good to understand why we excluded the DEM LERC files before, and what's changed to make us include them again.

I have updated the PR description.

@blacha blacha changed the title fix: enable Basemaps preview for Elevation data TDE-1151 fix: enable Basemaps preview for Elevation data TDE-1151 BM-932 Apr 17, 2024
@amfage amfage added this pull request to the merge queue Apr 18, 2024
Merged via the queue into master with commit 5f578a6 Apr 18, 2024
7 checks passed
@amfage amfage deleted the fix/enable-previews-for-elevation branch April 18, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0b0 l0b0 l0b0 left review comments

@paulfouquet paulfouquet paulfouquet approved these changes

@blacha blacha blacha approved these changes

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amfage @l0b0 @blacha @paulfouquet