Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(basemaps): Update the cogify workflow to support elevation imports. BM-998 #509

Merged
merged 5 commits into from
May 30, 2024

Conversation

blacha
Copy link
Member

@blacha blacha commented Apr 3, 2024

Motivation

The latest basemaps cogify supports elevation import with lerc presets. We can now update the workflow to support that as well.

Modification

  • Add the elevation related parameter to workflow.
  • Add a skip for create-overview as it is not supported for elevation.

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@Wentao-Kuang
Copy link
Contributor

Can we update the default basemaps-cli-version to v7 as well?

@Wentao-Kuang Wentao-Kuang changed the title [wip] feat: basemaps import dem process feat(basemaps): Update the cogify workflow to support elevation imports May 23, 2024
@Wentao-Kuang Wentao-Kuang changed the title feat(basemaps): Update the cogify workflow to support elevation imports feat(basemaps): Update the cogify workflow to support elevation imports. BM-998 May 23, 2024
@Wentao-Kuang Wentao-Kuang marked this pull request as ready for review May 23, 2024 22:35
@Wentao-Kuang Wentao-Kuang requested review from a team as code owners May 23, 2024 22:35
l0b0
l0b0 previously approved these changes May 24, 2024
Wentao-Kuang
Wentao-Kuang previously approved these changes May 28, 2024
@Wentao-Kuang Wentao-Kuang dismissed stale reviews from l0b0 and themself via f7f5e11 May 29, 2024 00:59
@blacha blacha added this pull request to the merge queue May 30, 2024
Merged via the queue into master with commit 52e8c79 May 30, 2024
3 checks passed
@blacha blacha deleted the feat/basemaps-dem branch May 30, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants