refactor: simplify cfn output logic #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
force-pushed
the
refactor/simplfy-logic
branch
from
8825b39 to
ed87f47
Compare
paulfouquet
approved these changes
Oct 29, 2023
amfage
pushed a commit
that referenced
this pull request
Oct 30, 2023
#### Motivation Use syntatical sugar to reduce the number of explicit checks needed #### Modification - Uses modern javascript syntax sugar - Avoids using `!object` or `if(object)` to prevent type conversions #### Checklist _If not applicable, provide explanation of why._ - [ ] Tests updated - [ ] Docs updated - [ ] Issue linked in Title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use syntatical sugar to reduce the number of explicit checks needed
Modification
!objectorif(object)to prevent type conversionsChecklist
If not applicable, provide explanation of why.