refactor: remove code duplication for namespace and sa creation #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
commented
Oct 26, 2023
config/eks/cluster.ts
Outdated
| fluentBitSa.node.addDependency(fluentBitNs); // Ensure the namespace created first | ||
| new CfnOutput(this, 'FluentBitServiceAccountRoleArn', { value: fluentBitSa.role.roleArn }); | ||
| const fluentbitSA = initService(this.cluster, 'fluentbit'); | ||
| new CfnOutput(this, 'FluentBitServiceAccountRoleArn', { value: fluentbitSA.role.roleArn }); | ||
|
|
||
| // Basic constructs for argo to be deployed into | ||
| const argoNs = this.cluster.addManifest('ArgoNameSpace', { |
There was a problem hiding this comment.
Does this service account have to be suffixed runner?
There was a problem hiding this comment.
I think argo has multiple service accounts, I think this was copied from the docs somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Namespace and SA creation logic is duplicated with different k8s component initialization.
Modification
Remove the duplication by calling a builder function
Checklist
If not applicable, provide explanation of why.