Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: argo sa arn is wrong #207

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: argo sa arn is wrong #207

merged 1 commit into from
Oct 26, 2023

Conversation

paulfouquet
Copy link
Collaborator

Motivation

The Argo service account ARN stored in cloudformation was the fluentbit one (copiy-paste mistake).

Modification

Change it to the right Argo SA ARN

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@paulfouquet paulfouquet requested review from a team as code owners October 26, 2023 19:43
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I assume you've tested this already.

@blacha blacha added this pull request to the merge queue Oct 26, 2023
Merged via the queue into master with commit 0f51b8b Oct 26, 2023
2 checks passed
@blacha blacha deleted the fix/argo-sa-arn branch October 26, 2023 20:29
amfage pushed a commit that referenced this pull request Oct 30, 2023
#### Motivation

The Argo service account ARN stored in cloudformation was the fluentbit
one (copiy-paste mistake).

#### Modification

Change it to the right Argo SA ARN

#### Checklist

_If not applicable, provide explanation of why._

- [ ] Tests updated
- [ ] Docs updated
- [ ] Issue linked in Title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants