fix: use template rcode NOERROR to prevent timeouts #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
reviewed
Oct 25, 2023
Co-authored-by: paulfouquet <[email protected]>
paulfouquet
approved these changes
Oct 25, 2023
MDavidson17
approved these changes
Oct 25, 2023
amfage
pushed a commit
that referenced
this pull request
Oct 30, 2023
#### Motivation When using `rewrite stop type AAAA A` DNS resolution would often hang for 30+seconds on the clients waiting for a response #### Modification Instantly respond to AAAA requests with a empty NOERROR to force clients to use A records for external hosts. #### Checklist _If not applicable, provide explanation of why._ - [ ] Tests updated - [ ] Docs updated - [ ] Issue linked in Title --------- Co-authored-by: paulfouquet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using
rewrite stop type AAAA ADNS resolution would often hang for 30+seconds on the clients waiting for a responseModification
Instantly respond to AAAA requests with a empty NOERROR to force clients to use A records for external hosts.
Checklist
If not applicable, provide explanation of why.