refactor: link both provisioners back to a shared node template #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
commented
Oct 25, 2023
l0b0
reviewed
Oct 25, 2023
blacha
commented
Oct 25, 2023
paulfouquet
approved these changes
Oct 25, 2023
amfage
pushed a commit
that referenced
this pull request
Oct 30, 2023
#### Motivation There appears to be a bug with cdk8s unsing nested specs causing volumes to show as ``` volumeSize: value: 200Gi ``` the value key is invalid, doing the exact same source as a node template outpus ``` volumeSize: 200Gi ``` to work around the problem use a shared node template. #### Modification Adds a shared aws node template for both spot provisionsers to reference. #### Checklist _If not applicable, provide explanation of why._ - [ ] Tests updated - [ ] Docs updated - [ ] Issue linked in Title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There appears to be a bug with cdk8s unsing nested specs causing volumes to show as
the value key is invalid, doing the exact same source as a node template outpus
to work around the problem use a shared node template.
Modification
Adds a shared aws node template for both spot provisionsers to reference.
Checklist
If not applicable, provide explanation of why.