Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add slack notification onExit TDE-842 #162

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

paulfouquet
Copy link
Collaborator

@paulfouquet paulfouquet commented Aug 28, 2023

Description

Trigger a Slack notification at the end of the create thumbnails workflow to post on #alert-argo-workflows.

image

@paulfouquet paulfouquet marked this pull request as ready for review August 28, 2023 20:38
@paulfouquet paulfouquet requested review from a team as code owners August 28, 2023 20:38
@paulfouquet paulfouquet marked this pull request as draft August 28, 2023 20:40
@paulfouquet paulfouquet marked this pull request as ready for review August 28, 2023 21:04
@blacha
Copy link
Member

blacha commented Aug 29, 2023

Before we merge this, I think we need to decide if we want to move our slack messaging from elastic into argo.

I think we need a bit of a pros/cons on if we think Argo is a better place for alerts? then also if we do decide to go with argo, some sort of migration path/plan for all the existing alerts?

@paulfouquet
Copy link
Collaborator Author

Before we merge this, I think we need to decide if we want to move our slack messaging from elastic into argo.

I think we need a bit of a pros/cons on if we think Argo is a better place for alerts? then also if we do decide to go with argo, some sort of migration path/plan for all the existing alerts?

Convert this PR to a draft until we talk about this.

@paulfouquet paulfouquet marked this pull request as draft August 30, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants