-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cogify): Update the cogify create cog to support topo raster. BM-1116 #3388
Open
Wentao-Kuang
wants to merge
11
commits into
master
Choose a base branch
from
feat/topo-raster-cog-creation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+118
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wentao-Kuang
added
container
build pull request container for testing
and removed
container
build pull request container for testing
labels
Jan 9, 2025
Wentao-Kuang
added
container
build pull request container for testing
and removed
container
build pull request container for testing
labels
Jan 10, 2025
Wentao-Kuang
added
container
build pull request container for testing
and removed
container
build pull request container for testing
labels
Jan 10, 2025
Wentao-Kuang
changed the title
feat(cogify): Update the cogify create cog to support topo raster.
feat(cogify): Update the cogify create cog to support topo raster. BM-1116
Jan 12, 2025
blacha
reviewed
Jan 12, 2025
Co-authored-by: Blayne Chard <[email protected]>
blacha
reviewed
Jan 12, 2025
|
||
return { | ||
command: 'gdal_translate', | ||
output: targetTiff, | ||
args: [ | ||
['-of', 'COG'], | ||
cfg.srcwin ? ['-srcwin', cfg.srcwin[0], cfg.srcwin[1], cfg.srcwin[2], cfg.srcwin[3]] : undefined, | ||
cfg.bigTIFF ? ['-co', `BIGTIFF=${cfg.bigTIFF}`] : ['-co', 'BIGTIFF=IF_NEEDED'], // BigTiff is somewhat slower and most (All?) of the COGS should be well below 4GB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need bigtiffs? everything should be well below 4gb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We set big tiff as no
in the topo-raster
, and If_needed
for all others atm.
Wentao-Kuang
added
container
build pull request container for testing
and removed
container
build pull request container for testing
labels
Jan 13, 2025
Wentao-Kuang
added
container
build pull request container for testing
and removed
container
build pull request container for testing
labels
Jan 13, 2025
Wentao-Kuang
added
container
build pull request container for testing
and removed
container
build pull request container for testing
labels
Jan 13, 2025
Wentao-Kuang
added
container
build pull request container for testing
and removed
container
build pull request container for testing
labels
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update the cogify create cog cli to support for both topo-raster cog and aerial raster cog creation together, so we can use the argo-task topo-stac-creation to prepare the stac files for topo raster map and reuse the create cog cli to do the cog creation.
Modifications
linz_basemaps:options
that allow to config into the dgal commands via these settings from stac files.tileId
to set as xyz Tile Id for aerial map or mapsheet Id for topo raster map.noReprojecting
to set in order to skip the reprojecting step ingdalwrapvrt
, as well as to set the target projection as the source indgaltranslate
linz:slug
if exists.Verification
Test imported topo raster previews:
Test workflow the topo raster standardised
Test basemaps import workflow with background.
Test on existing aerial map import feature that is not impacted.