Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Relocate dgal and cog from cli package. BM-879 #2984

Merged
merged 5 commits into from
Nov 2, 2023
Merged

feat(cli): Relocate dgal and cog from cli package. BM-879 #2984

merged 5 commits into from
Nov 2, 2023

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Nov 1, 2023 •
edited
Loading

Motivation

dgal and cog are using for bathymetry package, we don't need in the cli package. So can relocate them.

Modification

  • Move dgal into bathymetry package.
  • Move types of the cog job in to shared.
  • Remove the git from container as the pull request logic already inside argo-tasks
  • Remove the some tests.

Checklist

  • Tests updated
  • Docs updated
  • Issue linked in Title

@Wentao-Kuang Wentao-Kuang changed the title Relocate dgal into bathmery package, and Relocate cogJob types into s… feat(cli): Relocate dgal and cog from cli package. Nov 1, 2023
@Wentao-Kuang Wentao-Kuang changed the title feat(cli): Relocate dgal and cog from cli package. feat(cli): Relocate dgal and cog from cli package. BM-879 Nov 1, 2023
@Wentao-Kuang Wentao-Kuang marked this pull request as ready for review November 1, 2023 02:05
@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner November 1, 2023 02:05
@Wentao-Kuang Wentao-Kuang added this pull request to the merge queue Nov 2, 2023
Merged via the queue into master with commit 6ebb106 Nov 2, 2023
11 checks passed
@Wentao-Kuang Wentao-Kuang deleted the feat/refactoring-cli branch November 2, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacha blacha blacha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wentao-Kuang @blacha