Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli)!: Remove the old cog creation, serve, and sprites cli. BM-879 #2978

Merged
merged 7 commits into from
Oct 17, 2023
Merged

feat(cli)!: Remove the old cog creation, serve, and sprites cli. BM-879 #2978

merged 7 commits into from
Oct 17, 2023

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Oct 12, 2023 •
edited
Loading

Motivation

We have the new cogify working fine in the argo workflow with all bug fixed. We don't need this old one, should deprecate it and archive to make the cli package looks much cleaner.

Modification

  • Remove all the cog creation cli
  • Remove sprites cli - this now in the package/sprites
  • Still keeps some old cog types for job.json as we not reprocess all the old imagery yet.
  • Still need to keep cog creation log for the create-overview cli. We should move this cli in to cogify in the future.

Checklist

  • Tests updated
  • Docs updated
  • Issue linked in Title

@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner October 12, 2023 23:50
@Wentao-Kuang Wentao-Kuang changed the title feat(cli): Deprecate all the old cog creation, serve, and sprites cli. BM-879 feat(cli): Remove the old cog creation, serve, and sprites cli. BM-879 Oct 17, 2023
@blacha blacha changed the title feat(cli): Remove the old cog creation, serve, and sprites cli. BM-879 feat(cli)!: Remove the old cog creation, serve, and sprites cli. BM-879 Oct 17, 2023
@blacha blacha added this pull request to the merge queue Oct 17, 2023
Merged via the queue into master with commit 895b762 Oct 17, 2023
10 checks passed
@blacha blacha deleted the deprecate/old-cog branch October 17, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacha blacha blacha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wentao-Kuang @blacha