-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(lambda-tiler): correctly log fetch requests (#3359)
### Motivation Requests tracing has been broken for a while (not entire sure when it broke) It is very very helpful to have statistics on the number of s3 requests required to make a tile ### Modifications - `requestCount` is reserved for the number of lambda invocations so move to `fetchCount` for number of fetches - include the fetchIds to trace hot fetches - increase the percent of requests with tracing enabled - Use async local storage to gain access to the logger for the request that triggers the log message, this fixes a bug where the request may be in `trace` but the fetch is using the base logger which is set to `info` so no logs are generated. ### Verification Ran locally and verified logs are now appearing. <!-- TODO: Say how you tested your changes. --> --------- Co-authored-by: Wentao Kuang <[email protected]>
- Loading branch information
1 parent
a61b652
commit 9fa3681
Showing
4 changed files
with
19 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters