Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeJitter functionality to Wacom driver and update documentation #361

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mika314
Copy link

@mika314 mika314 commented Dec 2, 2024

  • Implement de-jitter logic to suppress small, erratic movements during click based on defined thresholds.
  • Introduce three new properties for de-jittering:
    • DeJitterEnable: Enables or disables de-jittering (default: off).
    • DeJitterThreshold: Sets the spatial threshold for movement suppression (default: 150, range: 0-1000).
    • DeJitterTimeThreshold: Sets the time threshold for movement suppression (default: 100ms, range: 0-10000ms).
  • Update the man page to include detailed documentation for the new properties.

mika314 and others added 3 commits December 1, 2024 19:48
- Implement de-jitter logic to suppress small, erratic movements during click based on defined thresholds.
- Introduce three new properties for de-jittering:
  - `DeJitterEnable`: Enables or disables de-jittering (default: off).
  - `DeJitterThreshold`: Sets the spatial threshold for movement suppression (default: 150, range: 0-1000).
  - `DeJitterTimeThreshold`: Sets the time threshold for movement suppression (default: 100ms, range: 0-10000ms).
- Update the man page to include detailed documentation for the new properties.
@jigpu
Copy link
Member

jigpu commented Dec 18, 2024

This is an interesting request! I'm a bit concerned about the suggested default values: a DeJitterThreshold of 150 can translate to quite a few pixels, depending on the tablet and screen (e.g. 150 would translate to ~7px for an Intuos Pro Medium paired with a 24" 1440p screen). I have not tried this patch yet to see how it feels with different tablet/screen combos, but it seems like it would make fine / precise drawing more frustrating. Not impossible, of course (the cursor will always move to the actual pen location after DeJitterTimeThreshold elapses), just more work to get the cursor to the desired pixel.

How did you arrive at this value? Is it tuned for your ideal feel (and if so, what tablet and screen resolution are you using)? Based on some measure of actual hand tremor magnitude?

@mika314
Copy link
Author

mika314 commented Dec 19, 2024

Drawing with dejitter enabled is quite a bad experience. On my end, I have a script that monitors which app is in focus and, if it's for example GIMP, it disables dejitter. It also switches between absolute and relative for apps that work badly in absolute mode, such as Parsec and Unreal Engine 5.

~7px sounds right. I was aiming to about that value. I did not use any science, just play around with values until it felt right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants