Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for kernels older than 4.18 #430

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

Pinglinux
Copy link
Member

@Pinglinux Pinglinux commented Jun 28, 2024

We decided to remove support for kernels older than 4.18 since

RHEL 8 runs on kernel 4.18
Ubuntu 20.04, the oldest Long Term Support version, runs on kernel 5.4
Debian 11, will be supported until June 30, 2026, is running kernel 5.10

There is only one "Error", which was led by a warning irrelevant to the change:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
{4.5 => 4.18}/Makefile.in | 0
Error: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

total: 0 errors, 1 warnings, 0 lines checked

Failure

@jigpu
Copy link
Member

jigpu commented Jul 2, 2024

Looking at the source of the checkpatch warning, it seems like it is not relevant to the input-wacom project. The warning is designed to ensure that if someone adds or removes files upstream, that they also make sure to update the MAINTAINERS file. We don't care about or even have a MAINTAINERS file, so this warning is meaningless for us.

The checkpatch script allows ignoring specific warnings. If we were running the script directly, adding --ignore FILE_PATH_CHANGES as an argument should fix this issue. Since we're running the script as an action though, it looks like we'll need to add a step to write a .checkpatch.conf file as described in the action documentation. We can make that a separate pull request though.

Copy link
Member

@jigpu jigpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the first and second commits together. This will ensure git bisect will work properly in the middle of this request.

@Pinglinux Pinglinux force-pushed the remove_older_then_4.18 branch 3 times, most recently from 9d8e7af to 6bbdb2e Compare July 3, 2024 02:48
Ping Cheng added 4 commits July 2, 2024 19:55
checkpatch throw a warning when it detects a file changed its path.
That's a kernel upstream concern. This project doesn't follow that
guideline. Ignore it.

Signed-off-by: Ping Cheng <[email protected]>
Prepare support for kernels 4.18 and later. Plus, adjust and cleanup
the configure.am and Makefile.am files for 4.18+ kernels.

Signed-off-by: Ping Cheng <[email protected]>
Remove code specific to kernels older than 4.18.

Signed-off-by: Ping Cheng <[email protected]>
Remove kernels older than 4.18 and add newer ones

Signed-off-by: Ping Cheng <[email protected]>
@Pinglinux Pinglinux force-pushed the remove_older_then_4.18 branch from 6bbdb2e to bdf6a03 Compare July 3, 2024 02:58
@jigpu
Copy link
Member

jigpu commented Jul 3, 2024

Thanks Ping, looks good to me.

@Pinglinux Pinglinux merged commit cfa708d into linuxwacom:master Jul 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants