HID: wacom: Remove AES power_supply after extended inactivity #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if a user does not use their AES pen for an extended period, the battery power supply attributes continue to exist. This results in the desktop showing battery status for a pen that is no longer in use and which may in fact be in a different state (e.g. the user may be charging the pen). To avoid confusion and ensure userspace has an accurate view of the battery state, this patch automatically removes the power_supply after 30 minutes of inactivity. Signed-off-by: Tatsunosuke Tobita <[email protected]> Reviewed-by: Jason Gerecke <[email protected]> Reviewed-by: Aaron Skomra <[email protected]> Reviewed-by: Josh Dickens <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Benjamin Tissoires <[email protected]> [[email protected]: Imported into input-wacom (fd2a9b29dc9c)] Signed-off-by: Tatsunosuke Tobita <[email protected]> Fixes:fd2a9b29dc9c ("HID: wacom: Remove AES power_supply after extended inactivity")
|
I fixed the very last line of the commit message since this change is not a fix of any issue, but improvement and elaboration for the driver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if a user does not use their AES pen for an extended period, the battery power supply attributes continue to exist. This results in the desktop showing battery status for a pen that is no longer in use and which may in fact be in a different state (e.g. the user may be charging the pen).
To avoid confusion and ensure userspace has an accurate view of the battery state, this patch automatically removes the power_supply after 30 minutes of inactivity.
Signed-off-by: Tatsunosuke Tobita [email protected]
Reviewed-by: Jason Gerecke [email protected]
Reviewed-by: Aaron Skomra [email protected]
Reviewed-by: Josh Dickens [email protected]
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Benjamin Tissoires [email protected]
[[email protected]: Imported into input-wacom (fd2a9b29dc9c)]
Signed-off-by: Tatsunosuke Tobita [email protected]