[WIP] Add keyboard shortcut s to toggle sidebar visibility #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Careful here, many hide(), show() calls are called on the sidebar already, when navigating through groups (for series, VOD etc..) and when toggling fullscreen. Also, if you add shortcuts you need to add the info in the keyboard shortcuts page. |
|
I have tried s in all situations I came across (and made sense to me) and never went into any problem(s) - besides, there was a toggle-sidebar shortcut before! But you are right: it has to be documented! Will try again ;) |
|
Well, now there is an info bar above the stream. It shows the name of the station and the stream url. Why? |
clefebvre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a keyboard shortcut s to toggle sidebar visibility