Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature: Made TV Channels sidebar resizable and hence hideable #271

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lakshminarayananb
Copy link

@lakshminarayananb lakshminarayananb commented Mar 6, 2023

Implementation for #44 :

  • Changed the TV group channel side bar as gtk-paned instead of gtk-box container
  • As gtk-box container already had only 2 child widgets inside - sidebar and playback_box, this is a straight swap to gtk-paned
  • Added gtk-frame inside gtk-paned to place the sidebar and playback_box as it was recommended per the gtk doc
  • Also, tidied up an existing behavior of the player showing an empty channels list when navigated from status bar 'Show' button. Now the side bar is hidden. This can be enhanced further by listing the channels from the group potentially later.

hypnotix_resize

This is my first contribution to a GTK project and appreciate any feedback, issues. Thanks.

@mtwebster
Copy link
Member

Hi, can you rebase this please? When #265 was merged it created a couple of conflicts (it was opened in January but merged after you opened yours, unfortunately).

Thanks

@clefebvre clefebvre changed the title Feature: Made TV Channels sidebar resizable and hence hideable [WIP] Feature: Made TV Channels sidebar resizable and hence hideable Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants