ddcci-multi-monitor@tim-we: Retry setting brightness and raise timeouts #6434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcalixte
reviewed
Sep 18, 2024
ddcci-multi-monitor@tim-we/files/ddcci-multi-monitor@tim-we/applet.js
Outdated
Show resolved
Hide resolved
Add a retry mechanism for setting the brightness (currently 16 times) and raise some timeouts (5s setting brightness, 500ms querying brightness).
qwertz19281
force-pushed
the
ddc-ci-slow-fix
branch
from
558121e
to
48c2dd6
Compare
|
The changes make sense and would probably fix some strange edge cases, so thanks for adding. |
rcalixte
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a retry mechanism to ddcci-multi-monitor@tim-we for setting the brightness and raise some timeouts.
For updating brightness, retry up to 16 times and increase timeout to 5000ms.
For querying, increase timeout to 500ms.
This should improve the DDC/CI brightness applet functionality with monitors which are slow/unreliable reading/updating DDC/CI brightness.
The way it is done (with the send/sent_brightness) also minimizes cascading of updates if the brightness is changed quickly in succession.
cc @GingerGigiCat @tim-we