app-launcher@mchilli: refactored code #6387
Conversation
mchilli
commented
Sep 8, 2024
mchilli
commented
- the widget will now be displayed more natively in the settings window
- this should also improve the handling when maximizing the window
- added a save and chancel button to reduce the effort of rebuilding the applet
- this should fix:Applet Bug app-launcher@mchilli #5519
- use a custom icon button ref:xlet-settings list widget - add/edit segfault cinnamon#12270
- update the screenshot
- update the translation files
There was a problem hiding this comment.
@mchilli Have you tested the translation support in this file?
There was a problem hiding this comment.
It worked for me for German. I didn't test every single translation, sorry. Hopefully it works.
Oh I see what you mean, I used cinnamon-xlet-makepot and not ./cinnamon-spices-makepot to create the pot file. There are some improvements compared to xlet-makepot, nice to know. But the strings in the glade file are not used by the script. Maybe I should delete them.
There was a problem hiding this comment.
It worked for me for German.
This is actually what I meant so it's good to know.
But the strings in the glade file are not used by the script. Maybe I should delete them.
You can set them as translatable and they should be detected. I thought I saw that the strings were detected too. If there are any that should be translated and were missed, we should try to fix it.
