Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --exclude-library option to standalone version #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dantti
Copy link
Contributor

@dantti dantti commented Jun 19, 2024

It would be useful to have the standalone version also able to exclude-libraries, this helps with issues:

#153
#150
#110
#108

@dantti dantti force-pushed the dantti/exclude_library_standalone branch from ee732b7 to a1cd6fc Compare June 19, 2024 13:17
@TheAssassin
Copy link
Member

We should use an environment variable, which then is usable both in standalone and plugin mode. Please see https://github.com/linuxdeploy/linuxdeploy/wiki/Plugin-system#controlling-plugin-behavior.

@dantti
Copy link
Contributor Author

dantti commented Aug 3, 2024

@TheAssassin I added the env var please look at linuxdeploy repo this is for the stand alone mode only

@TheAssassin
Copy link
Member

I'm not sure I quite understand you here. An environment implemented in linuxdeploy only has no effect in plugins at all unless they support them, too. Usually, it is preferable, though, to implement a specific one for the plugin. It's really low effort to export MYPLUGIN_SOMEVAR="$LINUXDEPLOY_SOMEVAR".

@dantti
Copy link
Contributor Author

dantti commented Aug 3, 2024

I'm talking about linuxdeploy/linuxdeploy#283

@dantti dantti force-pushed the dantti/exclude_library_standalone branch from a1cd6fc to 324d734 Compare August 4, 2024 02:07
@dantti dantti force-pushed the dantti/exclude_library_standalone branch from 324d734 to ac8d266 Compare August 11, 2024 14:45
@nuttyartist
Copy link

Hello, what's the status of this PR? @TheAssassin?

@Zaraka
Copy link

Zaraka commented Sep 25, 2024

Can this be merged? This is a problem everytime I'm trying to use linuxdeploy

@dantti
Copy link
Contributor Author

dantti commented Sep 25, 2024

while this is not merged you can either build it or use the files from my fork https://github.com/dantti/linuxdeploy-plugin-qt/releases/tag/continuous

It would be useful to have the standalone version also
able to exclude-libraries, this helps with issues:

 linuxdeploy#153
 linuxdeploy#150
 linuxdeploy#110
 linuxdeploy#108
@dantti dantti force-pushed the dantti/exclude_library_standalone branch from ac8d266 to f17765b Compare October 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants