-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable webengine deployment for Qt6 #113
Conversation
Will simply moving these modules to the Qt6 list break the plugin when used with Qt 6 releases that did not have these modules yet? Or we don't care for Qt 6.0 and 6.1 support anymore? |
@bjorn My 2 cents: I strongly recommend targeting only the LTS release in the 6.x series (ie 6.2.4) and later. 6.3.0 is also generally available and a transparent upgrade in my experience. I don't expect there to be any focus on 6.0.x or 6.1.x from qt.io themselves, so I think it is an unnecessary burden for this project, considering the overall overhead of the 5->6 transition. |
Right, I spent some time getting this plugin to work for 6.0 and 6.1 in #101, because there was some issue with switching my builds to 6.2. These have since been resolved though, so at this point I wouldn't mind to drop support for these Qt releases either. |
I'd just ignore Qt < 6.2 for now, honestly. We can consider these out of date. >= 6.2 bring plenty improvements, and I don't see any compatibility issues that would prevent anyone from upgrading. We should perhaps add a note in the README. @danryu could you please add this to your PR? |
@TheAssassin Added note to PR as requested. One thought: it's highly likely IMO that most (if not all) of the remaining modules in Qt6Modules are probably good to integrate at this stage in 6.x maturity. |
I guess so, but I'm not sure all of them have been reimplemented in Qt 6.2 already. Would be very willing to merge such a change, so if you have a few minutes, please feel free to update this PR (or send a new one), otherwise I'll merge this tonight. Thanks for your contribution! |
Merging for now. Thanks! |
@TheAssassin I'll do a separate PR for the other modules |
This PR enables the webengine deployer in linuxdeploy-plugin-qt for Qt6.
NOTE: 6.0.x and 6.1.x series are not supported. Current LTS release 6.2.4 (and later) bring many improvements with little or no compatibility issues.
Tested as working with Qt 6.2.4 and Qt 6.3.0 here: #112