Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make install part skippable #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knarfS
Copy link
Contributor

@knarfS knarfS commented Jun 25, 2021

In some scenarios the conda plugin has to be installed before the linuxdeploy process (not as a linuxdeploy plugin), e.g. when a Python environment is needed to build the application.
In this case, a cleanup must not be performed before the actual linuxdeploy process, but after it. Therefore it must be possible to skip the install part.

@TheAssassin
Copy link
Member

I see your point. But I think your approach is wrong here. I'd rather introduce a CONDA_CLEANUP_ONLY, which carries your intention a lot better. I guess the name is inspired by CONDA_SKIP_CLEANUP. However, I don't think this tool has two stages "install" and "cleanup" (I think more fine grainedly), or that it will be like that forever. CONDA_CLEANUP_ONLY is exactly the opposite of CONDA_SKIP_CLEANUP.

Have you seen linuxdeploy/linuxdeploy#68? Would introducing such stages fix the issue for you, or do you really need/want to manually set up a conda dir, then run your own script stuff, and then move on to cleaning up? I think with stages and a custom linuxdeploy plugin, you could likely achieve what you want to, too, but this is just a guess. I'd like to hear more about your use case. Perhaps you can share a script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants