Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libdmr): strip LoongArch out of Platform::Mips #500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MingcongBai
Copy link

LoongArch is not MIPS-based Loongson and exhibits significantly different performance characteristics (try ~50 - 100% faster with current hardware versus 3A4000).

There is no need to strip out functionalities in order to obtain acceptable performance. The current 3A6000 processors can easily keep up with 10th Gen Intel i3 processors.

Copy link

github-actions bot commented Aug 2, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

LoongArch is not MIPS-based Loongson and exhibits significantly different
performance characteristics (try ~50 - 100% faster with current hardware
versus 3A4000).

There is no need to strip out functionalities in order to obtain acceptable
performance. The current 3A6000 processors can easily keep up with 10th Gen
Intel i3 processors.
@MingcongBai
Copy link
Author

Re-submitted with company e-mail.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MingcongBai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MingcongBai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • compositing_manager.cpp文件中,注释应该准确反映代码的功能,而不是包含拼写错误。建议将注释修改为"match shenwei",以避免混淆。
  • compositing_manager.h文件中,注释应该保持简洁明了,避免使用复杂的句子和过多的细节。当前的注释"MIPS-based Loongson"已经足够清晰地表达了平台的意图。

是否建议立即修改:

  • 是,注释应该准确反映代码的功能和意图,以便于理解和维护代码。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 30, 2024

TAG Bot

New tag: 6.0.11
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants