-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: linglnog output parser and dbus interface #263
Conversation
Check ll-cli environment before install; Add json style ll-cli output parser; Deb package has higher priority than uab pacakge. Log: Check linglong env and json parser Influence: uab-package
Note
详情{
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/.clog.toml": [
{
"line": "repository = \"https://github.com/linuxdeepin/deepin-deb-installer\"",
"line_number": 2,
"rule": "S35",
"reason": "Url link | 2b6cd28425"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/src/deb-installer/main.cpp": [
{
"line": " app.setApplicationAcknowledgementPage(\"https://www.deepin.org/acknowledgments/deepin-package-manager/\");",
"line_number": 43,
"rule": "S35",
"reason": "Url link | e9c5f73d8f"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/src/deb-installer/view/pages/settingdialog.cpp": [
{
"line": " QString key = \"basic.develop_digital_verify.\";",
"line_number": 124,
"rule": "S106",
"reason": "Var naming | 0d12fe0ec0"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/assets/deepin-deb-installer.xml": [
{
"line": "<mime-info xmlns=\"http://www.freedesktop.org/standards/shared-mime-info\">",
"line_number": 1,
"rule": "S35",
"reason": "Url link | 4072667606"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/assets/data/deepin-deb-installer.json": [
{
"line": " \"key\": \"basic\",",
"line_number": 4,
"rule": "S106",
"reason": "Var naming | 3660712859"
},
{
"line": " \"key\": \"develop_digital_verify\",",
"line_number": 8,
"rule": "S106",
"reason": "Var naming | 8188451ec1"
},
{
"line": " \"key\": \"hierarachical_verify\",",
"line_number": 22,
"rule": "S106",
"reason": "Var naming | c5b960c181"
},
{
"line": " \"key\": \"proceedSecurity\",",
"line_number": 26,
"rule": "S106",
"reason": "Var naming | de17675c8a"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/debian/deepin-deb-installer.1": [
{
"line": "https://github.com/linuxdeepin/deepin-deb-installer",
"line_number": 43,
"rule": "S35",
"reason": "Url link | 2b6cd28425"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/debian/deepin-deb-installer-dependsInstall.1": [
{
"line": "https://github.com/linuxdeepin/deepin-deb-installer",
"line_number": 26,
"rule": "S35",
"reason": "Url link | 2b6cd28425"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/debian/control": [
{
"line": "Homepage: https://www.deepin.com/",
"line_number": 7,
"rule": "S35",
"reason": "Url link | 9095b9e112"
}
]
} |
Update installer DBus interface to support uab package. Log: The DBus interface supports uab package. Influence: uab-package
Note
详情{
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/.clog.toml": [
{
"line": "repository = \"https://github.com/linuxdeepin/deepin-deb-installer\"",
"line_number": 2,
"rule": "S35",
"reason": "Url link | 2b6cd28425"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/src/deb-installer/main.cpp": [
{
"line": " app.setApplicationAcknowledgementPage(\"https://www.deepin.org/acknowledgments/deepin-package-manager/\");",
"line_number": 43,
"rule": "S35",
"reason": "Url link | e9c5f73d8f"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/src/deb-installer/view/pages/settingdialog.cpp": [
{
"line": " QString key = \"basic.develop_digital_verify.\";",
"line_number": 124,
"rule": "S106",
"reason": "Var naming | 0d12fe0ec0"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/assets/deepin-deb-installer.xml": [
{
"line": "<mime-info xmlns=\"http://www.freedesktop.org/standards/shared-mime-info\">",
"line_number": 1,
"rule": "S35",
"reason": "Url link | 4072667606"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/assets/data/deepin-deb-installer.json": [
{
"line": " \"key\": \"basic\",",
"line_number": 4,
"rule": "S106",
"reason": "Var naming | 3660712859"
},
{
"line": " \"key\": \"develop_digital_verify\",",
"line_number": 8,
"rule": "S106",
"reason": "Var naming | 8188451ec1"
},
{
"line": " \"key\": \"hierarachical_verify\",",
"line_number": 22,
"rule": "S106",
"reason": "Var naming | c5b960c181"
},
{
"line": " \"key\": \"proceedSecurity\",",
"line_number": 26,
"rule": "S106",
"reason": "Var naming | de17675c8a"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/debian/deepin-deb-installer.1": [
{
"line": "https://github.com/linuxdeepin/deepin-deb-installer",
"line_number": 43,
"rule": "S35",
"reason": "Url link | 2b6cd28425"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/debian/deepin-deb-installer-dependsInstall.1": [
{
"line": "https://github.com/linuxdeepin/deepin-deb-installer",
"line_number": 26,
"rule": "S35",
"reason": "Url link | 2b6cd28425"
}
],
"/home/runner/work/deepin-deb-installer/deepin-deb-installer/sourceCode/debian/control": [
{
"line": "Homepage: https://www.deepin.com/",
"line_number": 7,
"rule": "S35",
"reason": "Url link | 9095b9e112"
}
]
} |
Add the wine pre-depends flag function; Add monitoring and tips for UAB file changes; Adjust the hierarchical signature verification dialog. Log: Fix tips for installation process.
deepin pr auto reviewFix deb-installer unit test error |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rb-union, starhcq The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A
feat: check linglong env and json parser
Check ll-cli environment before install;
Add json style ll-cli output parser;
Deb package has higher priority than uab pacakge.
Log: Check linglong env and json parser
Influence: uab-package
refactor: update the installer dbus interface
Update installer DBus interface to support uab package.
Log: The DBus interface supports uab package.
Influence: uab-package
fix: tip for installation process
Add the wine pre-depends flag function;
Add monitoring and tips for UAB file changes;
Adjust the hierarchical signature verification dialog.
Log: Fix tips for installation process.