-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
musl-cross-make: bump musl (1.2.0 -> 1.2.5) + rename module to reflect reality, bump newt ( whiptail:0.52.20 -> 0.52.24) to fix crash with newer musl #1841
Conversation
Created Dasharo/dasharo-issues#1126 for long time and more proper fix. This PR includes a patch for Talos, nothing more. |
…om ~0.9.9+->~0.9.10+ (musl 1.2.0 -> 1.2.5) Signed-off-by: Thierry Laurion <[email protected]>
…S against newer mulslc (Doesn't use coreboot buildstack, obviously) Signed-off-by: Thierry Laurion <[email protected]>
#1840 builds and is merged, rebasing on master |
f92407d
to
9e311b6
Compare
…l crash with newer muslc + parallel builds popt havent't changed. Signed-off-by: Thierry Laurion <[email protected]>
tested (factory-reset, passphrase change, reencryption, totp.hotp, TPM DUK, boot to final os:
|
size.txt analysis per linuxboot/heads-wiki#165 for x220-hotp-maximized (on the verge of getting umaintained...) But this is a gain, not a loss! See below. TLDR: the payload size is actually smaller, where all other numbers show counter intuitive increase in size. coreboot stitching outputThis PR:
Master:
switch to newer musl + newer newt (whiptail), change of empty space in CBFS: size.txt output diff
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Size reduction is surprising indeed but no complaints here 🙂
Not sure what to think of Nitrokey/nitrokey-hotp-verification#37 badluck? |
@tlaurion It was a one-off occurrence, not reproducible when running this MR again? If so it seems most likely unrelated. Hard to be 100% sure without identifying the actual cause, but given the nature of the issue and the changes here I think it is unlikely enough that we can merge. |
This is HOTP having been sealed in nk3 (can only be done once from Heads when nk3 secure element secret app has no PIN defined (in factory mode as shipped by Nitrokey), needs resetting through nitropy on second computer as of now) and was detailed under Nitrokey/nitrokey-hotp-verification#36 (comment) Will open an issue under Heads, from my understanding:
An image is 1000 words they say.
|
Thanks, makes sense. Not related to this change, let's merge 🚢 |
Putting again in draft mode, not quite sure why talos-2 doens't build, but there are hardcoded strings in code fro board name == talos-2 so will need fix for that too. |
bf9ac70
to
18fcc73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the latest changes, looks good to me. I looked over the talos-2 build directory changes pretty closely, especially the Linux config change, all looks right to me.
…name can change over time Signed-off-by: Thierry Laurion <[email protected]>
… to test nor report issues for this unknowingly used board prior of feature freeze planned for 2024-11-20 repro: helper used time docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make BOARD=talos-2 board.move_tested_to_untested Signed-off-by: Thierry Laurion <[email protected]>
Succeeded and saved cache. Inverting last two commits. |
18fcc73
to
a8ba6ba
Compare
This bumps musl-cross-make to 1.2.5+ and containes fixes for all boards to build.
Talos2: There is a bug with skiboot made obvious with absence of patch needed for skiboot to build with newer muslc, showing that skiboot builds with muslc, not coreboot buildstack. This is a temporary and ugly fix
TODO: