Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap some errors and fix static check error style warning #433

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

binjip978
Copy link
Collaborator

No description provided.

@binjip978 binjip978 changed the title wrap some error and fix static check error style warning wrap some errors and fix static check error style warning Sep 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 41.63%. Comparing base (19e147b) to head (38e313c).

Files with missing lines Patch % Lines
pkg/cbfs/image.go 0.00% 5 Missing ⚠️
pkg/cbfs/file.go 0.00% 1 Missing ⚠️
pkg/cbfs/payload.go 0.00% 1 Missing ⚠️
pkg/intel/microcode/microcode.go 90.00% 1 Missing ⚠️
pkg/uefi/file.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   41.63%   41.63%           
=======================================
  Files         142      142           
  Lines       10728    10728           
=======================================
  Hits         4467     4467           
  Misses       5393     5393           
  Partials      868      868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rminnich
Copy link
Contributor

until we have someone with windows, we might want to turn it off. It can't even seem to do anything but timeout.

@binjip978
Copy link
Collaborator Author

@rminnich do we squash or rebase here?

@rminnich
Copy link
Contributor

I think in this case squash and merge is appropriate

@binjip978 binjip978 merged commit cbe89b1 into linuxboot:main Sep 17, 2024
12 checks passed
@binjip978 binjip978 deleted the ST1005 branch September 17, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants