cleanup package usage #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangecms
previously approved these changes
Sep 17, 2024
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
=======================================
Coverage 41.63% 41.63%
=======================================
Files 142 142
Lines 10729 10728 -1
=======================================
Hits 4467 4467
+ Misses 5394 5393 -1
Partials 868 868 ☔ View full report in Codecov by Sentry. |
gofmt -r 'ioutil.ReadAll -> io.ReadAll' -w . gofmt -r 'ioutil.ReadFile -> os.ReadFile' -w . goimports -w . Signed-off-by: Ronald G. Minnich <[email protected]>
I'd prefer we stop using these non-standard flag parsers when possible, as we did in u-root. They add little value. Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
It is not clear why it is ok to ignore this error, but that is original code. Signed-off-by: Ronald G. Minnich <[email protected]>
binjip978
previously approved these changes
Sep 17, 2024
Signed-off-by: Ronald G. Minnich <[email protected]>
binjip978
approved these changes
Sep 17, 2024
|
no idea how to fix windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gofmt -r 'ioutil.ReadAll -> io.ReadAll' -w .
gofmt -r 'ioutil.ReadFile -> os.ReadFile' -w .
goimports -w .